<html>
<head><meta charset="utf-8"><title>nightly builds of salsa · t-compiler/rust-analyzer · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/index.html">t-compiler/rust-analyzer</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html">nightly builds of salsa</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="160720953"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160720953" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160720953">(Mar 13 2019 at 19:41)</a>:</h4>
<p>Hey <span class="user-mention" data-user-id="133169">@matklad</span> or others --</p>
<p>Are you able to build the rust-analyzer with the currently nightly?</p>
<p>After upgrading chalk to use salsa 0.10.0, I get errors like this with nightly:</p>
<div class="codehilite"><pre><span></span>Indexing chalk-solve
   Compiling salsa-macros v0.10.0
   Compiling lalrpop v0.16.0
   Compiling failure v0.1.5
error[E0412]: cannot find type `Result` in module `syn`
   --&gt; /home/nmatsakis/.cargo/registry/src/github.com-1ecc6299db9ec823/salsa-macros-0.10.0/src/database_storage.rs:190:42
    |
190 |     fn parse(input: ParseStream) -&gt; syn::Result&lt;Self&gt; {
    |                                          ^^^^^^ not found in `syn`
help: possible candidates are found in other modules, you can import them into scope
    |
1   | use core::fmt::Result;
    |
1   | use core::prelude::v1::Result;
    |
1   | use core::result::Result;
    |
1   | use std::fmt::Result;
    |
and 6 other candidates
</pre></div>



<a name="160721031"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160721031" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160721031">(Mar 13 2019 at 19:42)</a>:</h4>
<p>I'm testing salsa itself now</p>



<a name="160721043"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160721043" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160721043">(Mar 13 2019 at 19:42)</a>:</h4>
<p>hmm, that seems to build.</p>



<a name="160721073"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160721073" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160721073">(Mar 13 2019 at 19:43)</a>:</h4>
<p>I believe that's a bug with incremental compilation</p>



<a name="160721086"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160721086" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160721086">(Mar 13 2019 at 19:43)</a>:</h4>
<p><a href="https://github.com/rust-analyzer/rust-analyzer/issues/826" target="_blank" title="https://github.com/rust-analyzer/rust-analyzer/issues/826">https://github.com/rust-analyzer/rust-analyzer/issues/826</a></p>



<a name="160721153"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160721153" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160721153">(Mar 13 2019 at 19:44)</a>:</h4>
<p>though what you posted looks a little different</p>



<a name="160721170"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160721170" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160721170">(Mar 13 2019 at 19:45)</a>:</h4>
<p>ah, interesting</p>



<a name="160721172"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160721172" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160721172">(Mar 13 2019 at 19:45)</a>:</h4>
<p>that could be</p>



<a name="160721176"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160721176" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160721176">(Mar 13 2019 at 19:45)</a>:</h4>
<p>I don't get the failures on salsa itself</p>



<a name="160721180"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160721180" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160721180">(Mar 13 2019 at 19:45)</a>:</h4>
<p>though I get...other test failures</p>



<a name="160721253"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160721253" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160721253">(Mar 13 2019 at 19:46)</a>:</h4>
<p>hmm, disabling incremental doesn't seem to help</p>



<a name="160721262"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160721262" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160721262">(Mar 13 2019 at 19:46)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="123856">@Vadim Petrochenkov</span> -- do yo know if there were any bug fixes or other changes to name resolution that might be relevant to the error above?</p>



<a name="160721298"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160721298" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160721298">(Mar 13 2019 at 19:47)</a>:</h4>
<p>seems like <a href="https://docs.rs/syn/0.15.29/syn/type.Result.html" target="_blank" title="https://docs.rs/syn/0.15.29/syn/type.Result.html">syn::Result is a thing</a></p>



<a name="160721305"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160721305" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160721305">(Mar 13 2019 at 19:47)</a>:</h4>
<p>We have <a href="https://github.com/rust-lang/rust/issues/58291" target="_blank" title="https://github.com/rust-lang/rust/issues/58291">https://github.com/rust-lang/rust/issues/58291</a> filed for this issue. If it's not incremental it may be different</p>



<a name="160721320"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160721320" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160721320">(Mar 13 2019 at 19:47)</a>:</h4>
<p>I'll try with nightly</p>



<a name="160722875"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160722875" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160722875">(Mar 13 2019 at 20:07)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> I get the same issue I linked with nightly</p>



<a name="160722932"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160722932" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160722932">(Mar 13 2019 at 20:08)</a>:</h4>
<p>i.e., the one you linked above?</p>



<a name="160722935"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160722935" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160722935">(Mar 13 2019 at 20:08)</a>:</h4>
<p>ok</p>



<a name="160723234"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160723234" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160723234">(Mar 13 2019 at 20:12)</a>:</h4>
<p>yeah</p>



<a name="160730913"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160730913" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160730913">(Mar 13 2019 at 21:56)</a>:</h4>
<p>Resolution of paths like <code>syn::Result</code> isn't affected by incremental yet, AFAIK.<br>
Also, there shouldn't be any recent changes in that area.</p>



<a name="160731014"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160731014" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160731014">(Mar 13 2019 at 21:57)</a>:</h4>
<p>Perhaps <code>syn</code> accidentally refers to a local module named <code>syn</code>, or something like that?</p>



<a name="160785363"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/nightly%20builds%20of%20salsa/near/160785363" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/nightly.20builds.20of.20salsa.html#160785363">(Mar 14 2019 at 14:30)</a>:</h4>
<p><span class="user-mention" data-user-id="123856">@Vadim Petrochenkov</span> not that I know of. This error seems to happen only when building as part of another project, which is strange. I'll try to poke at a bit more today and see if I can reduce.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>